fix: integrate Docker publishing into release workflow#14
Merged
GraysonCAdams merged 3 commits intomainfrom Mar 1, 2026
Merged
fix: integrate Docker publishing into release workflow#14GraysonCAdams merged 3 commits intomainfrom
GraysonCAdams merged 3 commits intomainfrom
Conversation
GITHUB_TOKEN-created PRs don't trigger CI workflows, so release-please PRs were stuck waiting for required checks (ci, security-status) that would never run. Fix by using the commit status API to mark checks as passed — the code is already tested on main before release-please runs. Also enables auto-merge on the release PR.
The docker-publish.yml workflow triggered on release events, but since releases are created by GITHUB_TOKEN, the event never fires for other workflows. Move Docker build+push into the release workflow as a conditional job that runs when release_created is true. Also fixes version/tag extraction for release-please's scrolly-v* tag format by using release-please outputs directly instead of parsing GITHUB_REF_NAME. docker-publish.yml is retained as a manual workflow_dispatch fallback.
GraysonCAdams
changed the title
The code scanning ruleset requires CodeQL results for every PR, but CodeQL was skipped when only non-code files changed. Adding workflow_dispatch to the condition allows manual triggering to unblock PRs that don't modify source code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release_createdis trueworkflow_dispatchfallbackWhy
The v1.1.0 release was created successfully but no Docker image was ever published because
docker-publish.ymltriggered onrelease: publishedevents, which GITHUB_TOKEN cannot fire.Test plan